Open euantorano opened 6 years ago
effone
commented
6 years ago First of all the open <article> tag in HTML email template closes with </div>.
secondly, where are all the styling? I cant't see any inline CSS, data uri or link to any stylesheet in template.
I can come up with some mockups with responsive coded structure matching with MyBB blog site if there is chance of consideration and already not assigned to someone ...
euantorano
commented
6 years ago There is no styling checked in at the moment @effone - I'm not good at that kind of stuff, and just wanted to have something readable.
@Eric-Jackson was wanting to use some email templates we purchased, but if we use them we can't include the HTML in this repository due to copyright reasons. Personally I'd like to use something open source so that we can share the code here (which makes life a lot easier to deploy this app and get it running). Not sure what @Eric-Jackson and @justinsoltesz think of that.
effone
commented
6 years ago I have designed few templates few months back which I can modify and demonstrate. They are my own work, not even published anywhere. If I just be sure @Eric-Jackson or @justinsoltesz are not already working on it. I don't wanna spoil anyone's precious spent time.
Eric-Jackson
commented
6 years ago @effone it's just very important that they work across different OS and devices. How extensive is the testing you've done? Are they created in Mailchimp? The ones we have purchased are very high quality, I'd prefer to stick with them unless we can find an equal quality open source one.
effone
commented
6 years ago @Eric-Jackson I built the template using 'fluid-hybrid' method (following an exhaustive guide of tut+) and the templates are promisingly compatible. Honestly I could not test those in all devices as I don't have all kind of device, but so far I tested it went good. The big pain is to handle android gmail app as it simply discards media queries and the followed guide was taken care of that too including other problems like mso compatibility.
No, they are not created in Mailchimp and don't have mc: template language codes, but they can be added, if required ...
No problem, if we have already spent for something we should use its value ...
effone
commented
6 years ago OK. So, as much I have modified the look it comes out as:
Some fine-tuning might still be required, I can share the code if you guys want to take a look ... Or, may be just stick with the purchased ones as those must be well tested and best ...
euantorano
commented
6 years ago That looks pretty good to me. One thing to note is that the current code only has the subject, author name, date posted and the short summary of the post (not the full post). I can probably expand it to include categories/tags or anything else that might be useful.
On 23 Mar 2018, at 10:09, effone notifications@github.com wrote:
OK. So, as much I have modified the look it comes out as:
Some fine-tuning might still be required, I can share the code if you guys want to take a look ...
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.
effone
commented
6 years ago euantorano
commented
6 years ago Awesome, thanks @effone.
@Eric-Jackson Any ideas on the best way to test this, or should I simply load it up in the live instance I've got running and fire off a post?
effone
commented
5 years ago @euantorano as stated before this is easy to simulate a test mail using Litmus and check using various devices / mail clients.
effone
commented
5 years ago Refer to my earlier recommendation about Litmus, please consider looking at this Grunt Email Design Workflow repo that supports Mailgun as well as Litmus out of the box with cloud CDN support, and it produces error-free templates. I am sure this will come handy: https://github.com/leemunroe/grunt-email-workflow
The HTML email is currently extremely basic, with no styling. It should be tidied up to match the style of the MyBB blog.