search

mybb / mybb2

The repository for the MyBB 2 forum software. Not to be used on live boards.
https://www.mybb.com
BSD 3-Clause "New" or "Revised" License
109 stars 45 forks source link

Usage of models directly in User Presenter, needs to use repositories #134

Open wpillar opened 9 years ago

wpillar commented 9 years ago

https://github.com/mybb/mybb2/blob/master/app/Presenters/User.php#L245-249

wpillar commented 9 years ago

cc / @JN-Jones

JN-Jones commented 9 years ago

Should be in the settings package and be titled 'Add function/possibility to retrieve the settings for a special user' ;)

wpillar commented 9 years ago

Disagree, this issue is referring to the usage of it in the mybb2 code. If the resolution involves a change to the settings package, cool, but it's another issue.

Since you know what needs to be done, could you please file the issue on the setttings repo?