search

mybb / mybb2

The repository for the MyBB 2 forum software. Not to be used on live boards.
https://www.mybb.com
BSD 3-Clause "New" or "Revised" License
109 stars 45 forks source link

Escape language strings for JS #136

Open Destroy666x opened 9 years ago

Destroy666x commented 9 years ago

As I suggested under my lang commit, there should be some sort of support for languages which are often using apostophes (for example French) so that JS errors don't happen. Simply escaping them with Twig should be fine.

JN-Jones commented 9 years ago

There's only that "delete confirmation" dialog where this applies atm, isn't it? That one should be left for now as we'll likely use a modal/dialog instead of a js popup. But generally, yes, this should be added for sure.

ATofighi commented 9 years ago

I think it is fixed in https://github.com/mybb/mybb2/commit/260cf6c55cd7d08ab2739ee33e3d36b0486c0e1d

Destroy666x commented 9 years ago

https://github.com/mybb/mybb2/pull/159 seems to fix it indeed, at least the current lang strings.