search

mybb / mybb2

The repository for the MyBB 2 forum software. Not to be used on live boards.
https://www.mybb.com
BSD 3-Clause "New" or "Revised" License
109 stars 45 forks source link

Basic ACP Frontend #141

Closed wpillar closed 9 years ago

wpillar commented 9 years ago

Sets up a basic frontend that resembles this: https://files.slack.com/files-pri/T025VQ863-F043C95TC/screen_shot_2015-03-19_at_5.12.23_pm.png

Screenshot:

image

It's just enough to allow us to start building ACP functionality.

wpillar commented 9 years ago

@euantorano @JN-Jones think I fixed your issues, can you check I've done the breadcrumbs correctly?

euantorano commented 9 years ago

Looks good to me. Only got the above inline comment that I can see.

ATofighi commented 9 years ago

IMHO AdminCP JS/CSS codes shouldn't be in main.js / main.css and we should create admin.js / admin.css for it.

euantorano commented 9 years ago

Some of it will be shared, but the stuff only used in the ACP probably should go in separate files.

On 18 May 2015, at 21:02, AliReza Tofighi notifications@github.com wrote:

IMHO AdminCP JS/CSS codes shouldn't be in main.js / main.css

— Reply to this email directly or view it on GitHub.

wpillar commented 9 years ago

Fixed the naming issue (I agree). As for front-end, I'm inclined to agree that's why I've kept what I've done in very obviously separate files, I don't really want to get bogged down implementing a perfect front-end setup in this PR.

Someone more qualified than me will do a better job later on, just want to get the ACP ball rolling :D

euantorano commented 9 years ago

Yep, sounds fair to me. Justin and Eric are the front end wizards ;)

wpillar commented 9 years ago

:dancer: