search

mybb / mybb2

The repository for the MyBB 2 forum software. Not to be used on live boards.
https://www.mybb.com
BSD 3-Clause "New" or "Revised" License
110 stars 45 forks source link

Alpha 1 ACP Configuration + Settings #176

Open wpillar opened 9 years ago

wpillar commented 9 years ago
wpillar commented 9 years ago

@mybb/developers anything else to add here? Do we even have a table for settings / configuration yet? Do we even have any settings?

euantorano commented 9 years ago

Yep, we've got settings. You have to publish the migration from the settings package to get the table.

On 30 Aug 2015, at 16:17, Will Pillar notifications@github.com wrote:

@mybb/developers anything else to add here? Do we even have a table for settings / configuration yet? Do we even have any settings?

— Reply to this email directly or view it on GitHub.

wpillar commented 9 years ago

@euantorano ah of course, but we do need to expose those to editing in the ACP?

euantorano commented 9 years ago

@wpillar I think so, but I'm considering changing the settings lib a bit.

IMO, the main Manager should just handle reading settings, whilst changing them should be done using a SettingsRepository. This would simplify the whole Manager class and make it fit more inline with the rest of the core.

If everybody agrees, I'm going to fix that this week and hopefully open the Settings library to the public next weekend.