Timestamps

[chack1172]

In one of the last commits there's a problem. https://github.com/mybb/mybb2/commit/a33e0fbc2c002dc7069c978e6fd049ab4b7dd68d?diff=unified#diff-e6a42cbe15e7b8610cb2e34cf5f38577

$timestamps should be public or we get this error: Access level to MyBB\Core\Database\Models\User::$timestamps must be public (as in class Illuminate\Foundation\Auth\User)

[euantorano]

Yep, @JoshHarmon can you revert that change or shall I create a patch?

[JoshHarmon]

Yeah... The code sniffer led me astray there. I'll patch it up. The code sniffer doesn't like that so we either have to

• Make the sniffer shut up about that (which would be bad as it would effectively stop checking for proper encapsulation of everything, or
• Keep it private and use the accessor $user->shouldBeTimestamped() (which I created yesterday in that change) instead

joshharmon@Joshs-iMac  ~/Code/mybb2   master ●  composer sniff
> vendor/bin/phpcs

FILE: /Users/joshharmon/Code/mybb2/app/Database/Models/User.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 74 | ERROR | $timestamps must be "private" or "protected"
----------------------------------------------------------------------

[JoshHarmon]

Fixed in #226