search

mybb / mybb2

The repository for the MyBB 2 forum software. Not to be used on live boards.
https://www.mybb.com
BSD 3-Clause "New" or "Revised" License
111 stars 45 forks source link

Follow style guide #253

Closed Matslom closed 8 years ago

Matslom commented 8 years ago

My earlier changes in UserPresenter were mistake.

euantorano commented 8 years ago

Hi,

I believe that the two methods created_at and last_visit are needed in the UserPresenter as otherwise the member list and conversation view breaks.

Matslom commented 8 years ago

Normally they aren't needed. You need this methods in Presenter if u have null values in created/updated_at field (that's why I added them), but it shouldn't happend on correct working forum.

euantorano commented 8 years ago

Hi,

That would make sense, I will have to investigate further.