search

mybb / mybb2

The repository for the MyBB 2 forum software. Not to be used on live boards.
https://www.mybb.com
BSD 3-Clause "New" or "Revised" License
111 stars 45 forks source link

Fixes #203 Search #266

Closed JN-Jones closed 7 years ago

JN-Jones commented 7 years ago

203

Problem was that we assume that id is always an integer and add a pattern for that: https://github.com/mybb/mybb2/blob/master/app/Providers/RouteServiceProvider.php#L35 However the search id is a string so the route couldn't be found. I've simply renamed it to token in that route and fixed one more issue with the view.

@euantorano Probably we should rename the whole column everywhere to token to avoid any confusion.

euantorano commented 7 years ago

Yeah, renaming it to token everywhere would be best, can you amend this PR to do that?

JN-Jones commented 7 years ago

That was the plan. Need to take a look at migrations first though

euantorano commented 7 years ago

Nice one, cheers!

JN-Jones commented 7 years ago

Should be done now