euantorano
commented
7 years ago Looks good, kind of a big PR to review so we'll review it as we go. We may end up removing or changing some as we progress and find things aren't quite right.
Closed Azareal closed 7 years ago
euantorano
commented
7 years ago Looks good, kind of a big PR to review so we'll review it as we go. We may end up removing or changing some as we progress and find things aren't quite right.
Added return type-hints. Tweaked the docblocks to better match how the methods are being used. In some places, this includes removing docblock information which contradicted how the method was being used. Fixed a misnamed variable from my previous pull request. $role_id to $roleId in UserRepository.php
284