search

mybb / mybb2

The repository for the MyBB 2 forum software. Not to be used on live boards.
https://www.mybb.com
BSD 3-Clause "New" or "Revised" License
112 stars 45 forks source link

Update CONTRIBUTING.md #317

Closed 1e4 closed 6 years ago

1e4 commented 6 years ago

Fixed the headings to work properly - also changed SASS to SCSS as I'm pretty sure you mean SCSS and not SASS, just going to reference this SO answer as it provides a better description that I could, also your files are .scss so it makes sense to reference it as SCSS.

https://stackoverflow.com/a/27209555

justinsoltesz commented 6 years ago

Sass is correct.

http://sass-lang.com/

1e4 commented 6 years ago

@justinsoltesz Syntax wise MyBB2 is using SCSS not SASS, notice on the docs the syntax also says SCSS? http://sass-lang.com/guide

It's just symantics.

justinsoltesz commented 6 years ago

Sass is the CSS pre-processor, which is what the text you revised is referring to. Note the link in that block goes to the Sass website. The differentiation between .scss and .sass files is only in the syntax used. They're both still considered Sass.

1e4 commented 6 years ago

Fair enough, written using Sass pre processor but using sassy syntax. My bad

WildcardSearch commented 6 years ago

@1e4 Why close the PR? Just update the reviewed portion and we can still use this.

1e4 commented 6 years ago

@WildcardSearch I thought you have to close and create a new pull request for new changes?

JordanMussi commented 6 years ago

Just push a new commit to your patch-1 branch and you'll be good to go! :)

WildcardSearch commented 6 years ago

@1e4 nope. @JordanMussi is right. Just push a commit that changes SCSS back to SASS and then we can get this reviewed and accepted 😄

1e4 commented 6 years ago

Sorry @WildcardSearch @JordanMussi updated that now. Will remember in future