Closed wpillar closed 9 years ago
I'll have a look over this today. In regards to the slug, it should just be the user's name, but slugged (using Laravel's Str::slug()
, so My Username
becomes my-username
). It isn't used for lookups, just to provide "pretty" looking URLs :smile:
So when a user registers or changes username, their slug should be updated, and then just passed whenever building the URL to the profile.
Other than my nitpicks, this looks good :)
@euantorano think we're all good, anything else blocking a merge?
I don't believe so. I'm on mobile right now, but my last look through looked good :)
On 31 Mar 2015, at 20:50, Will Pillar notifications@github.com wrote:
@euantorano think we're all good, anything else blocking a merge?
— Reply to this email directly or view it on GitHub.
Great! :D if you could merge it when you get a chance, that'd be swell.
Pretty happy with this now, here's a summary:
Added
/user/<slug>.<id>
Form\Renderer
class that can take aForm\RenderableInterface
and generate the HTML for it. Input, select, or textarea. This is used by the custom profile fields to dynamically create form elements.form_render_field()
twig function that takes aForm\RenderableInterface
and uses theForm\Renderer
.UserController
currently used for the public facing user profile.profile_fields
table.profile_field_options
table.user_profile_fields
table.Future Work
Looking For
Looking for this PR to be reviewed with a view to merge, aim here is a stable MVP of the features described with scope for future work to be conducted separately.