Theme system - Githubissues

mybb / mybb2

The repository for the MyBB 2 forum software. Not to be used on live boards.

https://www.mybb.com

BSD 3-Clause "New" or "Revised" License

109 stars 45 forks source link

Theme system #44

Open euantorano opened 9 years ago

euantorano commented 9 years ago

There needs to be some kind of system to allow the creation of themes (or styles, not sure what to call them), allowing the installing of themes from third parties with customised CSS<,JavaScript and views.

Custom themes installed on the board should also be user selectable, so these details will have to be loaded fairly early in the application boot process.

euantorano commented 9 years ago

@Eric-Jackson @justinsoltesz What kind of features would you guys (as our resident designers) ideally like to see from the theme system for 2.0?

I've already got the following ideas:

[ ] Custom stylesheets (obviously).
[ ] Custom views (obviously).
[ ] Custom JavaScript management. Possibly using something such as Assetic, so that designers don't have to hardcode JS, instead there's a way to associate JS files with a theme and they'll be loaded automatically and merged into a single file.
[ ] Theme variables (such as those found in XF, vBulletin, etc.) - I'm not 100% set on this, but it might be nice I guess?
[ ] SASS for styles? Not sure on the feasibility of this, need to see if there are any libraries to parse SASS in PHP...

ATofighi commented 9 years ago

SASS for styles? Not sure on the feasibility of this, need to see if there are any libraries to parse SASS in PHP...

I agree with it, we can use https://github.com/leafo/scssphp

euantorano commented 9 years ago

Nice find @ATofighi!

ATofighi commented 9 years ago

I think we should support less too (https://github.com/leafo/lessphp)

euantorano commented 9 years ago

Maybe, but we don't want to overcomplicate it. We should probably ask the community.

JN-Jones commented 9 years ago

Themes should also get an update process similar to plugins (like Wordpress has).

euantorano commented 9 years ago

Agreed.

On 28 Apr 2015, at 16:36, Jones notifications@github.com wrote:

Themes should also get an update process similar to plugins (like Wordpress has).

— Reply to this email directly or view it on GitHub.

Eric-Jackson commented 9 years ago

A variable system would be amazing, I think we talked about style inheritance before which would be great as well.

In my opinion XF got just about everything right, so it's hard to suggest things without listing it's features. Something to relate templates so they could be grouped together when loaded would be awesome (xen:edithint).

Also something I thought would be interesting is the ability to export/import single templates (Or just any amount of them selected by the user). Would be cool for things like tutorials and add-ons where only small sections need tweaking (The CSS button tutorial for 1.6 comes to mind).

IPB's feature to export images as XML is also interesting, just to mention.

justinsoltesz commented 9 years ago

Sorry for being a little late to the party, but I think supporting SASS is pretty much required -- I've been writing the CSS to not just be able to manage for us, but also to be easy to manage for theme authors. Supporting SASS for custom themes also gives us theme variables (and a lot more) built-in.