mybb / mybb2

The repository for the MyBB 2 forum software. Not to be used on live boards.
https://www.mybb.com
BSD 3-Clause "New" or "Revised" License
109 stars 45 forks source link

Rename Command to AbstractCommand #53

Closed wpillar closed 9 years ago

wpillar commented 9 years ago

Our CONTRIBUTING file states that abstract classes MUST be prefixed with Abstract. L5 comes bundled with a bunch of abstract classes that do not conform to this convention.

Suggest we (read: I) rename them accordingly, starting with this one.

JN-Jones commented 9 years ago

Actually that class can be removed as we'll use MyBB/Core/Console/Commands instead (there's already one command). I don't think we need an abstract class for it.

wpillar commented 9 years ago

Fair enough :) What about these ones?:

JN-Jones commented 9 years ago

We haven't decided whether or for what we'll use events so I'd keep it for now. The rest is already used afair so should be renamed.

euantorano commented 9 years ago

Yeah, we'll be using events, but I'm not sure if we'll use that class as the base, or the existing base. You can definitely rename it though :)

wpillar commented 9 years ago

Ok, let's merge this one then and I'll rename the rest. If we don't need 'em we can delete 'em later.

euantorano commented 9 years ago

Ok, consider it merged!