search

mybbgroup / Isango

MyBB Simple Social Login / Register Using oAuth2
https://mybb.group/Thread-Isango
MIT License
5 stars 7 forks source link

Isango discord login wont transfer profile picture/name #55

Open deffcolony opened 3 years ago

deffcolony commented 3 years ago

Hi,

The plugin Isango is great with the discord registration feature only the problem is when i try to register on MYBB with the discord login it wont transfer the profile picture and name used on ur discord profile. It only transfer ur email name as username thats a privacy issue the discord login feature should transfer the profile name and profile picture from ur discord account

effone commented 3 years ago

We didn't consider those transfer as not all OAuth provider returns avatar and / or username. I'll however willing to work on it further to consider those return values if available in response.

Thanks for raising the issue.

Eldenroot commented 3 years ago

Maybe the username would be enough... avatar sync is nice and useful, but it will require a lot of more work to do (which could be an issue if we will add a lot of providers... to maintain it). Good idea so maybe in future?

effone commented 3 years ago

Avatar is already planned. The only to-do is if the remote avatar is not allowed we need to cache a local copy. ... and to identify which all gateways provide avatar URLs and by which parameter. Like this: https://github.com/mybbgroup/Isango/blob/master/upload/inc/plugins/isango/wordpress.ini#L15

Eldenroot commented 3 years ago

@effone - so avatar would be synced only during the registration, right? Because if it would be on every login, it will overwrite your local avatar settings which is not good.

effone commented 3 years ago

Only at the time of registration. Yes.

Eldenroot commented 3 years ago

OK, cool. Maybe we should open a new issue with all gateways which are supported right now and write where the sync of avatar is missing to track a progress. I will do that, OK?