Use versioning for JS files

mybbgroup / Thank-you-like-system

Thank you/Like system with MyAlerts support

https://mybb.group/Thread-Thank-you-like-system

GNU General Public License v3.0

11 stars 12 forks source link

Use versioning for JS files #233

Closed Eldenroot closed 4 years ago

Eldenroot commented 4 years ago

Just one idea - what about to use version number in JS files which are loaded in templates? It would avoid issues with "cached" JS during updates.

@lairdshaw

lairdshaw commented 4 years ago

It's a very good idea. I like it.

Eldenroot commented 4 years ago

What would be the best way to do apply this? Manually add ?ver=XXX where XXX will be the version number of plugin into the js url in template (MyBB way?)?

lairdshaw commented 4 years ago

Yes, that seems best. And remember to update the new 'version_at_last_change' property of the templates you change to the version of the next upcoming release.

Eldenroot commented 4 years ago

Added via https://github.com/mybbgroup/Thank-you-like-system/pull/236