Make timeout a configurable option

mybuddymichael / linter-elm-make

Lint your Elm files in Atom with elm-make

MIT License

32 stars 12 forks source link

Make timeout a configurable option #148

Closed MethodGrab closed 7 years ago

MethodGrab commented 7 years ago

A default 10 second timeout was added in https://github.com/steelbrain/atom-linter/commit/8096e6bfc5576567044259ea3f1610140129cc7e that kills the linter process if it takes longer than 10 seconds to run. The problem is, some large elm files take a lot longer than 10 seconds to lint. This option lets the user set a custom timeout to enable the linting of large files.

Fixes #147.

halohalospecial commented 7 years ago

@MethodGrab, thanks for the PR! The linter timeout is in milliseconds so we should either multiply the timeout setting by 1000 (and make it a float) or use milliseconds. My vote is with the former :smiley:

MethodGrab commented 7 years ago

Ah yes, so it is! I prefer the former also, I've pushed a fix.

halohalospecial commented 7 years ago

Thanks, @MethodGrab!