mycelium-com / wallet-android

Mycelium Bitcoin Wallet for Android
http://mycelium.com
Other
670 stars 323 forks source link

SegWit #379

Closed bom64 closed 5 years ago

bom64 commented 7 years ago

Thank you for Mycelium! I feel that it is important to implement SegWit tx ASAP because the block chain load will be lower and it will be clear that the split in November is unnecessary because all tx is confirmed fast.

I have try to find a date for the implementation.

Giszmo commented 7 years ago

We will provide SegWit at its time but if 2x winning or not depends on the fees on some date in November, then 2x won already because driving the fees up is easy compared to what is at stake.

Giszmo commented 7 years ago

Damn. Have to upgrade this to bug as our Trezor integration stopped working.

Sure, I could point to Trezor kicking Mycelium support but it's a system wide standard we have to implement anyway.

martin-lizner commented 7 years ago

Any ETA for SegWit support? Thanks.

rainulf commented 6 years ago

Any ETA? Need help? Let me know. Thanks!

bom64 commented 6 years ago

That delay give bcash power.....

bom64 commented 6 years ago

Electrum.org 3.0 support SegWit.

This stratic delay is an attack against Bitcoin and a help to "only bigger block" because they can say. See the fee. See SegWit. It don't work. I don't think Mycelium users like it.

damntourists commented 6 years ago

I am also interested in an ETA for the fix.

buttha commented 6 years ago

+1 without segwit support, mycelium is simply useless

HauRuck commented 6 years ago

Please give estimate for segwit support, otherwise I must start looking for a new wallet :-(

boland commented 6 years ago

Also waiting for segwit.

davidschou commented 6 years ago

+1 Your wallet is great, your fans are waiting for more greatness๐Ÿš€

RichAyotte commented 6 years ago

Love Mycelium but SegWit is a must so after many years of using and recommending Mycelium I'm now testing Samourai. It's not as featureful as Mycelium but it supports SegWit which is more important to me.

rainulf commented 6 years ago

Thanks @RichAyotte! Looks like Samourai is a good alternative to mycelium with SegWit support.

OferE commented 6 years ago

The fact that you don't support segwit makes this wallet very old. I don't want to use other wallets - but i will if you force me too.

Sorry - but i am forced to move to other wallet because you don't manage this correctly and you make bitcoin look bad.

seanlynch commented 6 years ago

Been a long time user of Mycelium. Even bought a Mycelium Entropy. But I've just moved all my coins to SegWit so I can't use Mycelium anymore :(

OferE commented 6 years ago

@seanlynch Mycelium was the best wallet for Android. So sad that they stopped developing it. There is Samurai that was recommended here - i never used it - it looks exactly how mycelium should look like. Comm'on Mycelium team - we don't want to leave you!

Giszmo commented 6 years ago

Guys, relax. This is totally over-the top emphasize of a non-issue. Transactions in which Mycelium users receive funds make up a tiny fraction of the blockchain. Please swamp the payment processors with such requests. There you can make a difference.

Also, SegWit is not a scaling solution because it gives us roughly 2MB blocks โ€“ it is a scaling solution because it enables things like lightning network.

Mycelium still has many features unmatched by other wallets and if you switch to a different wallet to save 50% on your fees, then I question your priorities, unless your actual monthly fees make up for more than 1% of your bitcoin holdings.

If we would be behind on LN, with many other wallets supporting it and no timeline from us, then I would agree but SegWit alone is not even a stepping stone to get to LN. Not on a wallet per wallet basis. We might get to LN in the same feature release that also, as a byproduct enables segwit.

bom64 commented 6 years ago

I do not understand: "Please swamp the payment processors with such requests. There you can make a difference."

Is it a special Bitcoin transaction?

And then a comment to: "Transactions in which Mycelium users receive funds make up a tiny fraction of the blockchain."

But you also say back in sep 8. that that SegWit will be implemented later so the fee can increase/mempool be full so the 2x can be activated: "We will provide SegWit at its time but if 2x winning or not depends on the fees on some date in November, then 2x won already because driving the fees up is easy compared to what is at stake."

First it is important not to implement SegWit so the mempool can be full and now is SegWit unimportant because very few Mycelium users receive tx and represent a tiny fraction of the blockchain.

In my point of view SegWit is the only scaling solution we have today if the right implementation is selected.

Yes, in the future Bitcoin get LN, new signature etc. - if there is no Show Stoppers...!

We have a scaling problem today because: a) No ETA for LN b) The last time mempool was empty was Oct 26, it is 30 days ago. https://ibb.co/euxNHm and https://jochen-hoenicke.de/queue/#30d c) User complain about high fee c1) https://bitinfocharts.com/comparison/median_transaction_fee-btc-bch.html#3m#log c2) "just paid $17 of bitcoin to secure a @blockstack ID, paid $5 in network fees. first time experiencing 30%+ tsxn fees." https://twitter.com/Melt_Dem/status/927592688412708864 d) SegWit adaptation is not increased http://segwit.party/charts/ e) The crypto currenty competition is real. Even a King can lose. Bitcoin is not the only coin. "What is BCash? BCash brings sound money to the world. Merchants and users are empowered with low fees and reliable confirmations. The future shines brightly with unrestricted growth, global adoption, permissionless innovation, and decentralized development." https://www.reddit.com/r/Bitcoincash/comments/7f9csc/bitcoin_gold_and_bitcoin_diamond_are_scam/

buttha commented 6 years ago

a non-issue

ROTFL I've moved all my BTC in segwit addresses and now I can't simply use my BTC with mycelium, so no: a) missing segwit support it's not a non-issue b) mycelium is a non-wallet

goodbye mycelium, goodbye

adamu commented 6 years ago

As a workaround, at the moment I'm just importing the trezor segwit keys individually as watch only addresses. Every time I make a transaction I open up a block explorer to get a QR code of the new change address, import it, and delete the old one. Obviously not possible to spend from these addresses within Mycelium though. And if you don't want to delete the old addresses because they could still receive funds, this results in a lot of single address accounts.

edit: This was in reply to a previous comment (now deleted) about Trezor recommending Mycelium to keep track of Trezor balances on mobile devices.

Transisto commented 6 years ago

Is mycelium contributing to Lighting development ? Segwit is a pre-requisite to lightning.

Going from 1mb to 2mb make a huge difference at this point in time.

Giszmo commented 6 years ago

Is mycelium contributing to Lighting development ? Segwit is a pre-requisite to lightning.

The company is currently not involved in lightning yet. We are pushing to get multi-blockchain, with a bitcoinJ based Bitcoin module, so that we can then quickly add lightning modules for those alts that support lightning and you will be able to do cross-chain lightning transactions. This development is a bit in conflict with "uh-oh-people are down-rating us for not supporting segwit. lets see if we can add segwit to our own library that we actually wanted to retire in favor of bitcoinj".

The Mycelium Wallet is a huge piece of software and many changes are relatively easy but they get harder with every addition, which is why we need to transition to a more scalable way of extending the wallet, also to not compromise the security of the private keys. This takes time and the tech demo of it is in the modularization branch here on github.

seanlynch commented 6 years ago

"The Mycelium Wallet is a huge piece of software and many changes are relatively easy but they get harder with every addition."

So you're saying the developers have built unmaintainable software and don't have the skills to refactor it. This is an even worse problem than the lack of SegWit support. Feeling pretty good about warning my friends and co-workers off of Mycelium now.

computerpoet commented 6 years ago

@seanlynch That is definitely not what @Giszmo said.

What he said was : "We are pushing to get multi-blockchain, with a bitcoinJ based Bitcoin module, so that we can then quickly add lightning modules for those alts that support lightning and you will be able to do cross-chain lightning transactions. "

@OferE We have not stopped working on the wallet, pretty far from it.

The new modular structure is right now in the "modularization branch here on github" as @Giszmo said. And there is a test APK available on the Google playstore. We are working on refining the kinks to put something secure and solid to production.

As far as segwit is concerned, we are currently discussing the best way forward to have it implemented (helping with the BitcoinJ effort in the segwit branch, as our spv module uses it, or another way) but can not provide a timeline yet.

seanlynch commented 6 years ago

@DaLN that is much nicer to hear than "You shouldn't care about a 50% reduction in transaction fees" and @Giszmo's other comments. I'd suggest asking him not to reply on issues anymore, since he's not doing a great job representing the team.

OferE commented 6 years ago

OK - if supporting alts has higher priority than segwit support - I have nothing to add here... Good luck - i'm out of here.

JohnKrakatoa commented 6 years ago

Hello, I came here because I wanted to use my Ledger nano S with my Mycelium but somehow it shows no account and I think it is because I have my account on my ledger on the segwit chain.....

I would also like if you implement segwit....

Giszmo commented 6 years ago

another collateral damage of our lack of segwit support is that the wallet cannot verify and thus ignores unconfirmed transactions from segwit outputs. Once they are confirmed, they show up as always.

Transisto commented 6 years ago

Every-time there is a high fee event people are fleeing Mycelium to a wallet that support Segwit / lower fees. I would have thought growing a user base was a high priority of a profit driven venture.

bom64 commented 6 years ago

Remember to implement SegWit using bech32: btcmanager.com/electrum-3-0-first-wallet-enable-bech32-segwit-addresses

My work around for this Mycelium only political CEO generated issue + [NO2X] is that I use Electrum 3.0 for receiving bitcoin. Don't move you Bitcoin to you own SegWit address because if all do so the mempool will be full forever.

bom64 commented 6 years ago

LN is two years away: "As far as Lightning Network changing the world โ€“ where I can wave my phone and pay for things and stuff will show up โ€“ I'd say it'll take a year or two," Mallers said. https://www.coindesk.com/lightning-bitcoin-scaling-tech-really-know/

The issue is: Higher fee but more important transaction that is impossible to complete with the current capacities because event if all pay 10.000 sat/B not all tx will be processed.

The VIP, CEO, invite only, price tag x,xxx USD, exclusive exclusion NYA was sentenced to fail because everyone (or some) who was kept outside the door became opponents. The CEO, VIP elite, should have seen this problem before the meting. It was not smart.

petrsykora commented 6 years ago

Please implement SegWit...

RichAyotte commented 6 years ago

Interesting Tweet that I thought I'd leave here to show that this feature hasn't been implemented for political reasons.

It took our team of 3 about 1 day to implement SegWit for both Bitcoin as well as Litecoin. What's the holdup .@coinbase .@blockchain et al?

https://twitter.com/byourseff/status/941644366795493376

Because of that, I'm unsubscribing from this issue and uninstalling Mycelium.

Pheromon commented 6 years ago

You think that segwit is relevant in paying less fees with your single sig account? Think again.

I don't see how paying 25$ instead of 30$ for your transaction makes things different.

Just use bitcoin cash and experience the breeze to pay fees of 0.01 $ ;-)

bom64 commented 6 years ago

Of cause it make sense bc it also lower the fee for all other users. So if many use pure SegWit then the fee in general will decrease.

Very, very few use bcash. https://fork.lol/tx/txs When very few was use bitcoin it was free.

Only bigger block is not the solution for Bitcoin.

fouadr commented 6 years ago

Just sended $600 from Trezor (segwit address) to Mycellium, nothing comes into Mycellium, doesn't show an incoming transaction. While it is confirmed on the (Segwit) blockchain ! Minutes later after Googling I guess Mycellium does not support Segwit, so, is my Money gone now?? I assumed that freshly installed Wallets ( especially Mycellium) would support also payments/deposits from/to Segwit addresses! wrong I gess ?

fouadr commented 6 years ago

Is there a way to get to my deposit on Mycellium? as mentioned in the post above?

Giszmo commented 6 years ago

@fouadr your transaction should show up in the wallet after being confirmed. If it doesn't, please contact our support at support@mycelium.com

bom64 commented 6 years ago

Is it a boycott of SegWit and is the reason [No2X]?

fouadr commented 6 years ago

I have received my funds! One day later ๐Ÿ˜‚๐Ÿ˜‚๐Ÿคฃ

scs3jb commented 6 years ago

Generated addresses don't look like segwit, any ETA?

earonesty commented 6 years ago

Can't import new Trezor. Is this a segwit thing?

jonathancross commented 6 years ago

@earonesty Probably is related if you sent funds to a newer segwit account (address beginning with 3...).

bom64 commented 6 years ago

Have Mycelium also plan to be unfair to btc again and boycott LN? I have noted that you have say that you want to focus on LN, but Myceliums explanation changes as time go.

maxkueng commented 6 years ago

I've read all those blog posts about how I can use Mycelium with the Trezor but since my coins are in SegWit addresses I was a bit disappointed when I wanted to try the wallet. There don't really seem to be any alternatives.

SegWit support would be really awesome.

Keep up the good work. And thanks

fsinisi90 commented 6 years ago

I already had a lot of patience, I'm changing to another wallet too. Bye bye Mycelium!

maxkueng commented 6 years ago

@fsinisi90 Which one?

OferE commented 6 years ago

samourai wallet

On Tue, Dec 26, 2017 at 11:25 PM, Max Kueng notifications@github.com wrote:

@fsinisi90 https://github.com/fsinisi90 Which one?

โ€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mycelium-com/wallet-android/issues/379#issuecomment-354014765, or mute the thread https://github.com/notifications/unsubscribe-auth/AB-znxKfPE1aWQlc2P2vXNnbXH19bHxLks5tEWQ1gaJpZM4PDpXI .

-- Regards, Ofer Eliassaf

maxkueng commented 6 years ago

@OferE But Samurai doesn't support hardware wallets.

gozur commented 6 years ago

The lack of segwit support defeats the whole purpose of this wallet app. Despicable