search

mycelium-com / wallet-android

Mycelium Bitcoin Wallet for Android
http://mycelium.com
Other
665 stars 322 forks source link

Fixing spelling, grammar, and sentence structure #470

Closed bexelbie closed 6 years ago

Giszmo commented 6 years ago

I said it before: Bit4commit does more harm than good and is a potential scam (the wast amount of tips remains in the pockets of whoever runs tip4commit even if there was activity and payouts). It encourages tiny or at least low-effort commits that cost more to review than to create pull requests.

Case in point, this PR introduces as many typos as it fixes, marginally tweaks semantics and provides little to no value to the user.

I tend to disregard PRs with an obvious association to tip4bit although I would rather want our brand to disappear from their list.

bexelbie commented 6 years ago

Projects are free to not accept PRs. However, I'd like to follow up on two of your comments:

  1. What typos are introduced in this PR? I submitted the fixes you find marginal in good faith. Again, you're free to reject them, I am not offended. But I'd like to know what I missed.

  2. I discourage you from assuming association with a project based on PR submission. I was reading in this area because of my work with open source communities. A key element of participation is that of fixing problems, even marginal or small ones, as you go. So yes, I fixed a typo in the tip4commit repo (amongst many) while reading about this form of controversial contribution inducement. I am not, however, associated with the project any more than a random committer to the Linux kernel would be considered "associated" with the kernel.