enable FLAG_SECURE by default & option to override

mycelium-com / wallet-android

Mycelium Bitcoin Wallet for Android

http://mycelium.com

Other

665 stars 322 forks source link

enable FLAG_SECURE by default & option to override #486

Closed maltfield closed 5 years ago

maltfield commented 5 years ago

This is a feature/security improvement request: please create an option for the user to toggle the FLAG_SECURE option in the mycelium bitcoin wallet android app, similar to the implementation in Signal.

https://github.com/signalapp/Signal-Android/issues/788

FLAG_SECURE should be on by default, and the option to toggle it off should be opt-in.

Giszmo commented 5 years ago

You say this would be a security improvement but as we prevent screenshots of xpriv already for example, I don't see the security improvement of optionally not preventing screenshots?

Giszmo commented 5 years ago

This is a duplicate of #471