search

mycelium-com / wallet-android

Mycelium Bitcoin Wallet for Android
http://mycelium.com
Other
659 stars 320 forks source link

No Local Trader Notifications #77

Open puggan opened 10 years ago

puggan commented 10 years ago

I'd like to get some kind of notice when a trader starts a trade, and tries to communicate with me. I guess you have build some kind of notification, that doesn't work on my phone. The settings have an option for "Play sound on Trade activity", the result from having that active (on my phone) is that i hear a sound, if i start mycelium, and open "Buy /Sell bitcoins", even if the activeity was a few days ago, the first notice i get is when i click the button "Buy /Sell bitcoins". (It's hard to trade if someone at Friday ask to meet up in the weekend, and I read it on Monday)

How dose it works on other phones? Is there some things i can test, to make it easier for you to find why It works diferent on my phone?

Mycelium: 1.2.2 Android: 2.3.7 Phone: Sony Experia ST27i

apetersson commented 10 years ago

in principle it should work, but only if you have play services active. do you have the play store installed and play services? on old android versions you also need an active google account. (only 2.2. afaik)

janmoller commented 10 years ago

We use Google Cloud Messaging to send out notifications. On Android 4.0.4 and forward you do not need a google account or the play store installed. As Andreas writes you need that on earlier versions.

puggan commented 10 years ago

Got a google account, and the "google play"-shop/store app. That where i installed mycelium from.

what is "play services"? Got alot of outer google service/apps: Gmail, hangout, google drive, google search, google maps, google maps street view, google plus, youtube

janmoller commented 10 years ago

On my Android 2.2.1 running Cyanogen Mod 6.1.1 notifications do not work. The first time I go into the Local Trader screens I get a popup explaining that it is not supported for my device. I think this may be due to Cyanogen Mod, but I am not certain. Do you remember whether you got a popup the first time you launched Local Trader?

On my off-the-shelf Androids v2.3.6, v4.0.3, 4.1.2, and v4.2.2 it works nicely

This is one of the things that are very hard to debug especially on older devices as the requirements are different prior to 4.0.4

From http://developer.android.com/google/gcm/gcm.html "It uses an existing connection for Google services. For pre-3.0 devices, this requires users to set up their Google account on their mobile devices. A Google account is not a requirement on devices running Android 4.0.4 or higher."

puggan commented 10 years ago

Everytime i go in to the trader i get an message, with the title "Welcome", but no info about something not working on my device.

Installed "GCM Test", and pinged my self, and that worked. https://play.google.com/store/apps/details?id=com.iapplize.gcm.test I also got a coluge to installet it, and message me, and it worked too. even when i closed the app. (using back-button).

Something more i can try to get some information about why?

raedah commented 8 years ago

I have this issue as well, and its been constant since, yeah, back in May 2014 or so. Android 5.0 and Android 6.0. No difference. Im on Cyanogenmod as well. Many many mycelium updates, but this bug persists.

DanielWeigl commented 8 years ago

The notification system depends on google-services and it seems it does not work under certain circumstances (we never were able to reliable reproduce it on our own) - so we implemented an optional notification via email: Go to Settings and set the Localtrader-notifcation Mail address.

raedah commented 8 years ago

Using email is not going to do the trick for me. Did you try running Mycelium Wallet on a phone with CyanogenMod? I have google services installed so shouldn't be an issue there. Where about in the code would this issue be located? What file? When opening the app, its not like it already has the data and just hadn't notified with a popup. When opening the app, its obviously only then polling the server and then retrieving updated information. So it takes some time after opening to find out if there are any new message, during which time the status indicator at the top right is spinning.

Giszmo commented 8 years ago

Can we close this in favor of #162 ?

raedah commented 8 years ago

@Giszmo What if #162 is closed later as 'not going to do'? Then what?

I did some testing on this issue and it seems there is a correlation to notification not working only when Mycelium is going through Tor. Currently I have Orbot support disabled, and the notifications are again working properly.

Giszmo commented 8 years ago

Sorry, @raedah you are right. This is not an issue of "I don't have google" but of "I have google but it still doesn't work at times".

Thank you for the TOR pointer. We will have to try that.