Pass `poolKeeper` and `autoClaim` as constructor arguments to the `PoolFactory`

mycelium-ethereum / perpetual-pools-contracts

Repo for Tracer Pool Swaps Protocol

26 stars 13 forks source link

Pass `poolKeeper` and `autoClaim` as constructor arguments to the `PoolFactory` #258

Closed CalabashSquash closed 2 years ago

CalabashSquash commented 2 years ago

At the moment, you have to set poolKeeper and autoClaim in two other separate steps after you deploy the PoolFactory. This doesn't make sense and you may as well set the m in the constructor.

Also update the deployment scripts (deploy poolKeeper and autoClaim before deploying poolFactory)

sporejack commented 2 years ago

Closed by #256 @mynameuhh ?

CalabashSquash commented 2 years ago

No, this is not added as part of that PR

sporejack commented 2 years ago

Sketch of solution:

[x] Add poolKeeper to constructor parameters for PoolFactory
[x] Add autoClaim to constructor parameters for PoolFactory
[ ] Update deployment scripts accordingly
- [x] Add new parameters
- [ ] Remove (now-redundant) calls to their respective setters

0xhrithik commented 2 years ago

Cannot pass poolKeeper and autoclaim contracts in as constructor parameters to the PoolFactory because those two contracts require the pool factory as a constructor parameter resulting in a circular dependency.