The theoretical largest change in mintingFee that could happen in a single update interval is by 100% (either moving from 100% minting fee to 0%, or vise-versa).
Therefore, we can set the maximum PoolCommitter::changeInterval to be 100%.
This also eliminates possibilities of changeInterval being so large that arithmetic overflows.
Changes
Add bytes16 public constant MAX_CHANGE_INTERVAL = MAX_MINTING_FEE;
Motivation
The theoretical largest change in
mintingFeethat could happen in a single update interval is by100%(either moving from 100% minting fee to 0%, or vise-versa). Therefore, we can set the maximumPoolCommitter::changeIntervalto be 100%.This also eliminates possibilities of
changeIntervalbeing so large that arithmetic overflows.Changes
bytes16 public constant MAX_CHANGE_INTERVAL = MAX_MINTING_FEE;