search

mychem / mychem-code

Mychem is an extension for MySQL that makes possible to use cheminformatics functions within SQL queries.
GNU General Public License v2.0
21 stars 14 forks source link

Role of STANDARD flag #24

Open merkys opened 3 years ago

merkys commented 3 years ago

I am trying to build Mychem with MariaDB 10.1.47 on Ubuntu 20.04. I face many compilation failures unless I turn on STANDARD flag in CFLAGS. However, I fail to find any documentation regarding this flag. Is it off by default to retain compatibility with MySQL proper?

Pansanel commented 1 year ago

Compilation warning / failures are linked to the following lines in CMakeLists.txt:

  if (CMAKE_SYSTEM_NAME MATCHES Linux)
    set( CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wno-long-long -std=iso9899:1990 -Wundef -Wcast-align -Werror-implicit-function-declaration -Wchar-subscripts -Wall -W -Wpointer-arith -Wwrite-strings -Wformat-security -Wmissing-format-attribute -fno-common")
    set( CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wnon-virtual-dtor -Wno-long-long -ansi -Wundef -Wcast-align -Wchar-subscripts -Wall -W -Wpointer-arith -Wformat-security -fno-check-new -fno-common")
  endif (CMAKE_SYSTEM_NAME MATCHES Linux)

Which version of GCC are you using?