Closed Mxrcon closed 2 years ago
the module level changes sees to be ok!, going to test the script changes nicely. I'm thinking that we should try to force MTBseq to use null references to see which modules really require references or maybe check logs to see if undesired params throw any warn.
we should try to force MTBseq to use null references to see which modules really require references
Sure, go ahead.
Other point to confirm could be to check the presence of the extra file parameters in the .command.sh
and .command.log
(which is created by MTBSeq)
@abhi18av what you think about the latest changes? let's proceed to testing?
I think they are on the right track @Mxrcon , thanks for the contribution. I'll merge the PR and finalize the changes after testing 👍
Let me just modify the pr body so we can have a description of these changes
Sure, you can always update the body using the Edit
icon :)
🚧 WIP 🚧