search

mycobactopia-org / MTBseq-nf

MTBSeq made simple and easy using Nextflow and nf-core standard.
https://doi.org/10.5281/zenodo.5498063
MIT License
8 stars 1 forks source link

[DEV] Adding a channel for references #48

Closed Mxrcon closed 2 years ago

Mxrcon commented 2 years ago

🚧 WIP 🚧

Mxrcon commented 2 years ago

the module level changes sees to be ok!, going to test the script changes nicely. I'm thinking that we should try to force MTBseq to use null references to see which modules really require references or maybe check logs to see if undesired params throw any warn.

abhi18av commented 2 years ago

we should try to force MTBseq to use null references to see which modules really require references

Sure, go ahead.

Other point to confirm could be to check the presence of the extra file parameters in the .command.sh and .command.log (which is created by MTBSeq)

Mxrcon commented 2 years ago

@abhi18av what you think about the latest changes? let's proceed to testing?

abhi18av commented 2 years ago

I think they are on the right track @Mxrcon , thanks for the contribution. I'll merge the PR and finalize the changes after testing 👍

Mxrcon commented 2 years ago

Let me just modify the pr body so we can have a description of these changes

abhi18av commented 2 years ago

Sure, you can always update the body using the Edit icon :)