mycodeself / mongo-migrate-ts

Run mongodb migrations easy from TypeScript
MIT License
86 stars 26 forks source link

fix: removed depreciated @types/mongodb #93

Closed gustawdaniel closed 9 months ago

gustawdaniel commented 1 year ago

now types are included to Mongodb package updated a few packages, like typescript minor fixes in types, added awaits, removed any

mycodeself commented 1 year ago

Hi @gustawdaniel

thanks a lot for your contribution, I really appreciate it.

Looking at the changes there are some changes that I don't think are necessary, if I am not mistaken produced by some linter or similar. Some examples are:

While I am not against these changes, I think some of them could be discussed and it does not make sense to put them in same PR.

Would you mind leaving this PR for the purpose of this PR only? I see the following scope:

What do you think? I'm open to any comment you might have! and again, thanks for your contribution!

gustawdaniel commented 1 year ago

I will do it next week.