mycognosist / solar

A minimal Secure Scuttlebutt replication node.
Other
20 stars 2 forks source link

Split configuration according to modules #55

Closed mycognosist closed 1 year ago

mycognosist commented 1 year ago

See aquadoggo for a nice pattern, where module-level config is neatly separated and combined into a top-level configuration object: https://github.com/p2panda/aquadoggo/blob/main/aquadoggo/src/config.rs

So we should end up with NetworkConfiguration, JsonRpcConfiguration, MuxRpcConfiguration and ReplicationConfiguration.

This should also help with https://github.com/mycognosist/solar/issues/24

mycognosist commented 1 year ago

Make sure to implement a validate() method for the Cli struct.

mycognosist commented 1 year ago

Done.