mycomplexsoul / delta

To do list, money manager, media tracker, last time task was done and scaffolding generator
0 stars 0 forks source link

Update dependency nodemailer to v6.9.9 [SECURITY] #481

Closed renovate[bot] closed 7 months ago

renovate[bot] commented 8 months ago

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
nodemailer (source) 6.9.1 -> 6.9.9 age adoption passing confidence

GitHub Vulnerability Alerts

GHSA-9h6g-pr28-7cqp

Summary

A ReDoS vulnerability occurs when nodemailer tries to parse img files with the parameter attachDataUrls set, causing the stuck of event loop. Another flaw was found when nodemailer tries to parse an attachments with a embedded file, causing the stuck of event loop.

Details

Regex: /^data:((?:[^;];)(?:[^,])),(.)$/

Path: compile -> getAttachments -> _processDataUrl

Regex: /(<img\b[^>] src\s=[\s"']*)(data:([^;]+);[^"'>\s]+)/

Path: _convertDataImages

PoC

https://gist.github.com/francoatmega/890dd5053375333e40c6fdbcc8c58df6 https://gist.github.com/francoatmega/9aab042b0b24968d7b7039818e8b2698

Impact

ReDoS causes the event loop to stuck a specially crafted evil email can cause this problem.


Release Notes

nodemailer/nodemailer (nodemailer) ### [`v6.9.9`](https://togithub.com/nodemailer/nodemailer/blob/HEAD/CHANGELOG.md#699-2024-02-01) [Compare Source](https://togithub.com/nodemailer/nodemailer/compare/v6.9.8...v6.9.9) ##### Bug Fixes - **security:** Fix issues described in GHSA-9h6g-pr28-7cqp. Do not use eternal matching pattern if only a few occurences are expected ([dd8f5e8](https://togithub.com/nodemailer/nodemailer/commit/dd8f5e8a4ddc99992e31df76bcff9c590035cd4a)) - **tests:** Use native node test runner, added code coverage support, removed grunt ([#​1604](https://togithub.com/nodemailer/nodemailer/issues/1604)) ([be45c1b](https://togithub.com/nodemailer/nodemailer/commit/be45c1b299d012358d69247019391a02734d70af)) ### [`v6.9.8`](https://togithub.com/nodemailer/nodemailer/blob/HEAD/CHANGELOG.md#698-2023-12-30) [Compare Source](https://togithub.com/nodemailer/nodemailer/compare/v6.9.7...v6.9.8) ##### Bug Fixes - **punycode:** do not use native punycode module ([b4d0e0c](https://togithub.com/nodemailer/nodemailer/commit/b4d0e0c7cc4b15bc4d9e287f91d1bcaca87508b0)) ### [`v6.9.7`](https://togithub.com/nodemailer/nodemailer/blob/HEAD/CHANGELOG.md#697-2023-10-22) [Compare Source](https://togithub.com/nodemailer/nodemailer/compare/v6.9.6...v6.9.7) ##### Bug Fixes - **customAuth:** Do not require user and pass to be set for custom authentication schemes (fixes [#​1584](https://togithub.com/nodemailer/nodemailer/issues/1584)) ([41d482c](https://togithub.com/nodemailer/nodemailer/commit/41d482c3f01e26111b06f3e46351b193db3fb5cb)) ### [`v6.9.6`](https://togithub.com/nodemailer/nodemailer/blob/HEAD/CHANGELOG.md#696-2023-10-09) [Compare Source](https://togithub.com/nodemailer/nodemailer/compare/v6.9.5...v6.9.6) ##### Bug Fixes - **inline:** Use 'inline' as the default Content Dispostion value for embedded images ([db32c93](https://togithub.com/nodemailer/nodemailer/commit/db32c93fefee527bcc239f13056e5d9181a4d8af)) - **tests:** Removed Node v12 from test matrix as it is not compatible with the test framework anymore ([7fe0a60](https://togithub.com/nodemailer/nodemailer/commit/7fe0a608ed6bcb70dc6b2de543ebfc3a30abf984)) ### [`v6.9.5`](https://togithub.com/nodemailer/nodemailer/blob/HEAD/CHANGELOG.md#695-2023-09-06) [Compare Source](https://togithub.com/nodemailer/nodemailer/compare/v6.9.4...v6.9.5) ##### Bug Fixes - **license:** Updated license year ([da4744e](https://togithub.com/nodemailer/nodemailer/commit/da4744e491f3a68f4f68e4073684370592630e01)) ### [`v6.9.4`](https://togithub.com/nodemailer/nodemailer/blob/HEAD/CHANGELOG.md#694-2023-07-19) [Compare Source](https://togithub.com/nodemailer/nodemailer/compare/v6.9.3...v6.9.4) - Renamed SendinBlue to Brevo ### [`v6.9.3`](https://togithub.com/nodemailer/nodemailer/blob/HEAD/CHANGELOG.md#693-2023-05-29) [Compare Source](https://togithub.com/nodemailer/nodemailer/compare/v6.9.2...v6.9.3) - Specified license identifier (was defined as MIT, actual value MIT-0) - If SMTP server disconnects with a message, process it and include as part of the response error ### [`v6.9.2`](https://togithub.com/nodemailer/nodemailer/blob/HEAD/CHANGELOG.md#692-2023-05-11) [Compare Source](https://togithub.com/nodemailer/nodemailer/compare/v6.9.1...v6.9.2) - Fix uncaught exception on invalid attachment content payload

Configuration

šŸ“… Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

šŸš¦ Automerge: Enabled.

ā™» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

šŸ”• Ignore: Close this PR and you won't be reminded about this update again.



This PR has been generated by Mend Renovate. View repository job log here.

renovate[bot] commented 8 months ago

āš  Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

ā™» Renovate will retry this branch, including artifacts, only when one of the following happens:

The artifact failure details are included below:

File name: package-lock.json
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: delta@1.14.5
npm ERR! Found: @angular/animations@17.0.1
npm ERR! node_modules/@angular/animations
npm ERR!   @angular/animations@"17.2.1" from the root project
npm ERR!   peerOptional @angular/animations@"17.0.1" from @angular/platform-browser@17.0.1
npm ERR!   node_modules/@angular/platform-browser
npm ERR!     @angular/platform-browser@"17.2.1" from the root project
npm ERR!     peer @angular/platform-browser@"17.0.1" from @angular/forms@17.0.1
npm ERR!     node_modules/@angular/forms
npm ERR!       @angular/forms@"17.2.1" from the root project
npm ERR!     2 more (@angular/platform-browser-dynamic, @angular/router)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! @angular/animations@"17.2.1" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: @angular/core@17.2.1
npm ERR! node_modules/@angular/core
npm ERR!   peer @angular/core@"17.2.1" from @angular/animations@17.2.1
npm ERR!   node_modules/@angular/animations
npm ERR!     @angular/animations@"17.2.1" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /tmp/renovate/cache/others/npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /tmp/renovate/cache/others/npm/_logs/2024-02-15T14_34_10_980Z-debug-0.log