search

mycontroller-org / MyControllerDevice

MyController supported MQTT ESP8266 library
http://www.mycontroller.org
Apache License 2.0
4 stars 4 forks source link

Increase size for password/username #13

Open cimba007 opened 6 years ago

cimba007 commented 6 years ago

Would it be possible to increase password/username size form 16 to 32 bytes?

One remark:

#define MQTT_MAX_PACKET_SIZE 512 //This one is not working have to check it

This has to be manually changed on 

D:\Users\Jinja\Documents\Arduino\libraries\PubSubClient\src\PubSubClient.h
jkandasa commented 6 years ago

@cimba007

Would it be possible to increase password/username size from 16 to 32 bytes?

Yes, it is possible, I will update

define MQTT_MAX_PACKET_SIZE 512 //This one is not working have to check it

Yes, this is known the issue. I do not know how to pass this change from MyConfig.h to PubSubClient

cimba007 commented 6 years ago

From my limited knowledge about makros it seems that it is not possible. I see no problem to directly edit it in the PubSubClient config file.

jkandasa commented 6 years ago

@cimba007 When I increase this username and password size to 32 bytes, will cause to reconfigure all the existing running devices. Is that fine?

cimba007 commented 6 years ago

For me this is fine. From my oppinion it would be a great addition if all the parameters could be set during "setup" from the sketch too. During testing I had some trouble as I had do reset the configuration multiple times and it was very time consuming to connecto to the ESP and enter all the data again.

for example: "mc.setSSID("SSID"), mc.setWlanPasswort("PASSPHRASE"), mc.skipWebConfigure(true)" .. just a suggestion.

Am 20.11.2017 06:01 schrieb Jeeva Kandasamy:

@cimba007 [1] When I increase this username and password size to 32 bytes, will cause to reconfigure all the existing running devices. Is that fine?

-- You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub [2], or mute the thread [3].

* {"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mycontroller-org/MyControllerDevice","title":"mycontroller-org/MyControllerDevice","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mycontroller-org/MyControllerDevice"}},"updates":{"snippets":[{"icon":"PERSON","message":"@jkandasa in #13: @cimba007 When I increase this username and password size to 32 bytes, will cause to reconfigure all the existing running devices. Is that fine?"}],"action":{"name":"View Issue","url":"https://github.com/mycontroller-org/MyControllerDevice/issues/13#issuecomment-345592453"}}}

Links:

[1] https://github.com/cimba007 [2] https://github.com/mycontroller-org/MyControllerDevice/issues/13#issuecomment-345592453 [3] https://github.com/notifications/unsubscribe-auth/ADSwwXE1jrzXux4qvJf4gotvnrmaWHm7ks5s4QfEgaJpZM4Qffm3