mycontroller-org / mycontroller-v1-legacy

The Open Source Controller
http://www.MyController.org
Apache License 2.0
147 stars 90 forks source link

Сustom messages with NEW keys for notifications SMS, Email, Pushbullet note #321

Closed devicter closed 7 years ago

devicter commented 7 years ago

Please add a new key ${notification.actualUnit}

Custom message example: Inside temperature goes too high! Current temperature is ${notification.actualValue} ${notification.actualUnit}

result: Inside temperature goes too high! Current temperature is 35 °C

so it will be more versatile enough just to make one rule and substituted it anywhere.

jkandasa commented 7 years ago

This feature included on recent SNAPSHOT build.

devicter commented 7 years ago

in the final version there is a bug again ${notification.actualUnit} gives the value of Type (for example Temperature) and most likely it should be called ${notification.actualType}

errtype

jkandasa commented 7 years ago

@devicter Thank you! I have updated the fix and available on latest SNAPSHOT version.