captainPrime commented 1 year ago

Issue - #161

Description

Success and error messages are displayed based on the state of the Vuex store. If the report is successfully submitted (report_success is true), a success message is shown. Conversely, if there is a failure (report_failed is true), an error message is displayed.

The submit button triggers the postReport method when clicked. This method first resets the form using resetForm(), which clears the form data by setting the corresponding properties of formData to their initial values. Then, it dispatches a "submitReport" action to the Vuex store, passing the formData object as the payload.

The is_loading computed property is used to determine if the submit button should display a loading state. It retrieves the modal_isLoading state from the Vuex store.

Overall, this component provides a user interface for reporting issues and submitting a form with relevant information. The form data is managed through Vuex, and the form submission triggers actions to handle the submission process and display appropriate success or error messages.

How Has This Been Tested?

[✅] Manual tested on my local
[✅ ] e2e test

Checklist:

[ ] I have rebased my branch against the base branch
[✅] My code follows the style guidelines of this project (4 spaces instead of 2)
[✅] I have performed a self-review of my code.
[✅] I have cleaned my commits

fokosun commented 1 year ago

Looking good so far! ty! Just those 2 comments, conflict resolution, rebase against dev and squash your commits.

fokosun commented 1 year ago

hey @captainPrime can you add a actions workflow to run the automated tests in this PR? We can create another issue for that if you think it'd bloat this PR up? We'd also need to add a workflow for code style just to make sure we are all on the sake page.

captainPrime commented 1 year ago

hey @captainPrime can you add a actions workflow to run the automated tests in this PR? We can create another issue for that if you think it'd bloat this PR up? We'd also need to add a workflow for code style just to make sure we are all on the sake page.

i created the workflow in this branch

fokosun commented 1 year ago

Just one last thing, squash your commits then I'll merge. You can squash all to just one then amend the commt message to something like:

issue-161: Implement the ability for a user to report a recipe

On your terminal

git rebase -i HEAD~9 

# because you have 9 commits 
# in edit mode, starting from the last one at the bottom of the list of commits, change pick to `s`, leave the very first one at the top as pick. Hit esc then `:wq` to save then enter edit mode again, change the commit message to the example above then save. force push

fokosun commented 1 year ago

@captainPrime is this now fully ready to be re reviewed?

mycookbook / web-client

feat: implemented report recipe functions #167

Issue - #161

Description

How Has This Been Tested?

Checklist: