mycoralhealth / mycoral-patient

Mobile app for patients to interact with Coral Health blockchain
17 stars 7 forks source link

Change to shared records tab #16

Open philipparkergit opened 6 years ago

philipparkergit commented 6 years ago

I’ve edited the wording a bit. We should show who you’ve shared records with instead of who shared records with you. Should be a quick change. Just need to switch those icons and names to be doctors instead of peers.

nosequeldeebee commented 6 years ago

22 and this should be one ticket. Closing the other one

lukecyca commented 6 years ago

I agree that "who have I shared this with" is a more common use case than "who has shared stuff with me". And that we are currently missing the former.

I think the "View Medical Record" screen should include a list of who the record has been shared with. Then it is easy to see who a particular record has been shared with, rather than have to hunt through a list of the people who you've shared anything with you to see which specific records they have access to.

Then we can leave the "Shared Records" screen to cover the latter use case (as it was). Or if this is too confusing right now as a fringe case, we could remove it.

philipparkergit commented 6 years ago

Yeah good point. I actually think both are important. For a given record in "View Medical Record" it's nice to be able to see who that it has been shared with. I think it's also super valuable to have that screen of who you've shared anything with. that allows you to get a quick sense of everyone who currently has access to your records. we could eventually use that screen to let the user give access to all medical records to a specific doctor or easily take away all access. because "who have I shared this with" is so important it's good for it to have its own screen and have that screen be in the middle of the bottom menu as it is now.

I think the use case of "who has shared stuff with me" is really a fringe case. personally I wouldn't share access even with my emergency contact. I think it would be better to not have that as a default option but rather have it as an optional add on that people can opt into using the settings menu. wouldn't need it for this release though.

On Sun, Feb 4, 2018 at 3:54 PM, Luke Cyca notifications@github.com wrote:

I agree that "who have I shared this with" is a more common use case than "who has shared stuff with me". And that we are currently missing the former.

I think the "View Medical Record" screen should include a list of who the record has been shared with. Then it is easy to see who a particular record has been shared with, rather than have to hunt through a list of the people who you've shared anything with you to see which specific records they have access to.

Then we can leave the "Shared Records" screen to cover the latter use case (as it was). Or if this is too confusing right now as a fringe case, we could remove it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mycoralhealth/mycoral-patient/issues/16#issuecomment-362938786, or mute the thread https://github.com/notifications/unsubscribe-auth/AiAaFIWYyoWkNtMtVLMp9IA10nDpGWG0ks5tRhkMgaJpZM4R4bWA .

-- Philip Parker Chief Operating Officer Coral Health philipparker@mycoralhealth.com 617-429-3805

nosequeldeebee commented 6 years ago

Hey Phil, Luke and I discussed this. To get something out quickly it would take less effort to add sharing history by test and reverting the "Shared Records" to what it was. All this with the understanding that this is mutable and we will probably have an option for the Shared Records page to see both types (shared with me, and who I shared with) in next iteration

nosequeldeebee commented 6 years ago

Phil and I discussed after you left yesterday @lukecyca

Let's go with what you suggested with being able to see people with whom you've shared your records by test

And also implement a toggle in the "Shared records" screen where you can switch between people who have shared records with you, and vice versa. The default would be people you've shared records with.

see #27

nosequeldeebee commented 6 years ago

new workflow:

all records show up on "Shared Records" screen and they can filtered by who shared with you, and whom you shared with