search

mycoralhealth / mycoral-patient

Mobile app for patients to interact with Coral Health blockchain
17 stars 7 forks source link

Removing second title on the add genetic test and add basic heart measures screens #19

Closed philipparkergit closed 6 years ago

philipparkergit commented 6 years ago

Suggest removing h3 title that appears directly above the date because it's redundant with the page title.

lukecyca commented 6 years ago

Right now the page title is "View Medical Record" which is different than the specific record type in the H3.

We could move the latter up to the former, and remove the H3. However given the number of fields in our two record types, I think the current layout looks better because it fills out the screen and calls more attention to the record type.

philipparkergit commented 6 years ago

Sorry about that. I think we might be talking about different screens. I meant screen "AddBloodTestRecordScreen.js". Right now the screen title says "Add Blood Test". Below that, but above the date, it says in large font "Blood Test". I think the screen title is sufficient and we can remove that second "Blood Test".

Same comment for the corresponding Genetic Test screen.

On Sun, Feb 4, 2018 at 4:01 PM, Luke Cyca notifications@github.com wrote:

Right now the page title is "View Medical Record" which is different than the specific record type in the H3.

We could move the latter up to the former, and remove the H3. However given the number of fields in our two record types, I think the current layout looks better because it fills out the screen and calls more attention to the record type.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mycoralhealth/mycoral-patient/issues/19#issuecomment-362939252, or mute the thread https://github.com/notifications/unsubscribe-auth/AiAaFD3DtO_NojKPbJ_zJb5c47GYClzVks5tRhqQgaJpZM4R4bzH .

-- Philip Parker Chief Operating Officer Coral Health philipparker@mycoralhealth.com 617-429-3805

nosequeldeebee commented 6 years ago

Luke is going to change the workflow slightly so this becomes less of an issue:

1) When adding a record, you can either add manually or add by camera (not have a giant list of random colors and icons for different tests) 2) if "add manually" is selected you can choose a list of tests from there 3) then you add the test, header stays the same (Add Record) and the test name is in the body, which would elegantly address this ticket

philipparkergit commented 6 years ago

Yeah that's a good solution. Too many tests will eventually be supported to have separate buttons for each.

On Sun, Feb 4, 2018 at 4:45 PM, Andy Park notifications@github.com wrote:

Luke is going to change the workflow slightly so this becomes less of an issue:

  1. When adding a record, you can either add manually or add by camera (not have a giant list of random colors and icons for different tests)
  2. if "add manually" is selected you can choose a list of tests from there
  3. then you add the test, header stays the same (Add Record) and the test name is in the body, which would elegantly address this ticket

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mycoralhealth/mycoral-patient/issues/19#issuecomment-362942565, or mute the thread https://github.com/notifications/unsubscribe-auth/AiAaFKCf5amyLc2BAvE_vpoWPxIlrLGfks5tRiThgaJpZM4R4bzH .

-- Philip Parker Chief Operating Officer Coral Health philipparker@mycoralhealth.com 617-429-3805