Closed mycroes closed 11 months ago
That's pure coincidence 😉
Note: ATM I'm not actively thinking about the issue here, but please feel free to ping me if you'd like review, tipps, etc. (anything where you think I can help out).
Will do, for now I have to rework my benchmarks as well because of my mishap with trying to encode data using larger primitives, it makes me feel terribly stupid 🤦🏻♂️ . I need to look into Vector128
and see what that offers for me, seems that might give me some performant solutions to everything serialization related in Sally7.
I think I should perhaps just follow everything @gfoidl on GitHub, maybe that leads to solutions for any problem I have 😉 On a (slightly) more serious note, I do enjoy seeing your name appearing in issues or PR's that interest me, that also makes me proud that you're spending time on reviewing Sally7 as well.
Thanks ❤️
Well I use Sally7 for a business project...so I'm interested in what's going on here. Hooray for open source! And the discussions in the PRs we had were very intersting and helpful. I think we both learned quite a lot and that should continue.
@gfoidl Care to take a final look at this? I think it can be merged as-is.
I hugely messed up on the 'serialize as larger primitive', that's not going to work. However I found https://github.com/dotnet/runtime/pull/76339, which gives me some new ideas to try out. As a coincidence (or not) @gfoidl is involved again 🤣