search

mycroftw / bridge_clock

Python replacement for the old windows XP clock I've been using
GNU General Public License v3.0
0 stars 0 forks source link

Invisible breaks on wrong round #34

Closed mycroftw closed 1 month ago

mycroftw commented 9 months ago

if you ask for "break after 6" visible, it does exactly that.

If you ask for "break after 6" invisible, it adds to round 6 ?

mycroftw commented 1 month ago

Issue is in _next_round(), where we check before updating the round if we have a visible break, but after the round change if it's invisible. Need to change the logic so that the test happens and the time is added before updating the round number.

mycroftw commented 1 month ago

Actually, not sure this is an issue - the time is added to the round you want the break after - "hiding" the break now page. If you have a break after round 6, Round 6 will have extra time, and Round 7 would start at the time it would if there was a visible break after round 6.

I should ask a couple of TDs what they expect to have happen.

mycroftw commented 1 month ago

Discussion with other TDs; this is how it should work. "Break after 4" should add time to round 4, as we would do by hand.