search

mycurelabs / vue-wysiwyg

A simple wysiwyg editor for Vue.js
https://mycurelabs.github.io/vue-wysiwyg/
MIT License
51 stars 13 forks source link

fix id and classes and css #14

Closed signmeuptwice closed 4 years ago

signmeuptwice commented 4 years ago

hopefully that helps

jofftiquez commented 4 years ago

WTH did you do to the README?

signmeuptwice commented 4 years ago

WTH did you do to the README?

I changed it on my fork to reflect the npm publication... mistake ?

igemnace commented 4 years ago

WTH did you do to the README?

I changed it on my fork to reflect the npm publication... mistake ?

This is fine, I just don't believe we can make use of this PR in its current form.

Are there any changes from your fork that you believe would be useful for us? If so, you can isolate the work into a branch, free from any fork-specific changes (e.g. naming changes), and submit that as a PR.

signmeuptwice commented 4 years ago

Sorry kind of new to this... first fork and PR for me... I believe the useful changes are up to 769960e for you. I guess I could checkout the branch to 769960e ?

igemnace commented 4 years ago

Yep, that could work. We can review the changes in that case.

signmeuptwice commented 4 years ago

I have since uncovered quite a few other issues with the editor; in particular with loosing cursor selection. So I will be fixing those first before pr. I guess we can close this pr

jofftiquez commented 4 years ago

@signmeuptwice thanks. Please avoid unnecessary customizations to the README or other parts of the app.