mydea / PikadayResponsive

A responsive datepicker built on top of Pikaday. It shows the native datepicker on mobile devices and a nice JS-picker on desktop.
https://mydea.github.io/PikadayResponsive/
MIT License
166 stars 25 forks source link

Use min and max date for native datepicker #24

Closed Gerain2k closed 6 years ago

Gerain2k commented 6 years ago

Hi, I think it might be useful to have min and max attribute set for native datepicker. I know that it is not fully supported by iOS devices but it does work on Android. You can do some thing like this: `$input = $("<input type='date' class='pikaday__invisible' placeholder='" + settings.placeholder + "' min='"

mydea commented 6 years ago

I'd gladly accept a PR to add this functionality! I'm not actively adding features to this right now, so would depend on someone else adding it. I can also guide you if you need help.

Gerain2k commented 6 years ago

Sure thing I will make a PR ether today or tomorrow.

Gerain2k commented 6 years ago

Hey I was about to build project with my updates and have a question: Should I upgrade to new version of momentjs and pickaday or leave the old ones?

mydea commented 6 years ago

From my view, you can update all dependencies as long as stuff still works afterwards ;)

Gerain2k commented 6 years ago

Great. Can you invite me to collaborate so I can make a PR? Oh I see I should have forked this repo