search

mydnic / laravel-feedback-component

Customizable Feedback Component for Laravel
MIT License
271 stars 26 forks source link

CSS and Composition API #146

Open chrispmcgee opened 4 weeks ago

chrispmcgee commented 4 weeks ago

I would love to customize this in our Vue.js+inertia Laravel app. However, I see that the Vue files published with vendor:publish are using the Options API rather than the Composition API. This normally isn't a big problem, but using require() to import other components is. We don't use require(), so I guess I would have to change every require() line in each component into an import statement instead.

I'd like to propose that the Vue files be updated to the import syntax and possibly even move the Vue components over to the Composition API.

I have also noticed that the styling is done in a .scss file. Unfortunately, we don't use Sass in our app and I doubt I'd be allowed to add that overhead. Is there a chance to convert it to a regular CSS3 file instead? Or, better yet, if you convert the Vue file into a SFC using the Composition API, then you could just put all the CSS into that same file in a <style scoped> element.

Thoughts?

mydnic commented 4 weeks ago

Hey there!

That would be absolutely nice and it will be something I'll work on... when I'll work on this package. Unfortunately I hove zero time to work on this package as of now. I still want to continue to work on it and upgrade the whole codebase, it's just impossible atm.

i'm definitely open to review and merge PR in the meanwhile