mydockfinder / mydockfinder-for-Win10-Win11

1.09k stars 273 forks source link

Stage manager animation #730

Open elkhaligy opened 2 months ago

elkhaligy commented 2 months ago

Stage manager animation is broken on any version above 1.9.7.7, I don't know how you're not able to tell this with this amount of attention to details, the application being minimized is not supposed to appear on top while being minimized, Please fix this I already bought your app.

mydockfinder commented 2 months ago

What is the version of your system I'm win11 and everything is fine

------------------ 原始邮件 ------------------ 发件人: @.>; 发送时间: 2024年8月24日(星期六) 中午11:06 收件人: @.>; 抄送: @.***>; 主题: [mydockfinder/mydockfinder-for-Win10-Win11] Stage manager animation (Issue #730)

Stage manager animation is broken on any version above 1.9.7.7, I don't know how you're not able to tell this with this amount of attention to details, the application being minimized is not supposed to appear on top while being minimized, Please fix this I already bought your app.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

elkhaligy commented 2 months ago

What is the version of your system I'm win11 and everything is fine ------------------ 原始邮件 ------------------ 发件人: @.>; 发送时间: 2024年8月24日(星期六) 中午11:06 收件人: @.>; 抄送: @.>; 主题: [mydockfinder/mydockfinder-for-Win10-Win11] Stage manager animation (Issue #730) Stage manager animation is broken on any version above 1.9.7.7, I don't know how you're not able to tell this with this amount of attention to details, the application being minimized is not supposed to appear on top while being minimized, Please fix this I already bought your app. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.>

Windows 11 23H2

  1. There's a difference between v19.7.7 Stage manager animation and the recent versions

  2. Setting menu stutters in newer versions

  3. Maximizing an app makes a flicker after the animation has been done in newer I will upload 1 video for each case, I am really sad that this is the case for me for newer versions as I really liked the dark icons

  4. Stage manager different animation As we see in the first video, the animation is 1:1 to the macos real animation, where the app being minimized is behind and app being maximized is in front

https://github.com/user-attachments/assets/09333faa-797c-4abe-909d-a825a5a86ba1

Here in the second video, you can see how the animation is clunky in newer versions, seems like the app getting minimized is brought in front of the other app middle animation

https://github.com/user-attachments/assets/bc388c3d-c687-42c1-ac55-c3903b0be1f5

  1. Setting stuttering In the first video we can see how settings doesn't stutter a bit in the older version

https://github.com/user-attachments/assets/0e423fd2-d098-4fd6-81de-8d363ebb412c And in the second video it stutters like hell, newer version

https://github.com/user-attachments/assets/77be5fa3-c878-4fff-ac89-6d980db9099e

  1. Maximizing an app flicker In the older version, maximizing an app doesn't make a flicker, here's the two videos comparison

https://github.com/user-attachments/assets/4087eb28-5fff-48f2-b91b-f568f84e4221

See how the app flicker after the animation is done https://github.com/user-attachments/assets/8059901f-d94b-4a98-8aeb-388832b9b74a

mydockfinder commented 2 months ago

It turned out to be a preference interface.,It's supposed to be a side effect caused by rewriting the global interface and changing to WinUI.,I'll try to optimize it.。 Minimizing window flickering suggests that turning on minimized dynamic refresh in Preferences - Minimization can solve this problem

elkhaligy commented 2 months ago

Seems like obs for some reasons wasn't able to capture the app flicker problem, hmm, why it is not visible on the recording?!

I also wants to mention that the older version feels smoother overall, which is not visible also in the recordings as obs post processing smooths out the video

elkhaligy commented 2 months ago

It turned out to be a preference interface.,It's supposed to be a side effect caused by rewriting the global interface and changing to WinUI.,I'll try to optimize it.。 Minimizing window flickering suggests that turning on minimized dynamic refresh in Preferences - Minimization can solve this problem

That's good to hear, can you bring the newer features on the older version? it is really smooth, makes my laptop feels alive

mydockfinder commented 2 months ago

I'm trying to optimize it, and if it doesn't work, I'll refactor the interface, but I can't change back to the old code, because the animations and effects of the interface will be smooth with WinUI

------------------ 原始邮件 ------------------ 发件人: @.>; 发送时间: 2024年8月24日(星期六) 中午12:42 收件人: @.>; 抄送: "№じ @.>; @.>; 主题: Re: [mydockfinder/mydockfinder-for-Win10-Win11] Stage manager animation (Issue #730)

It turned out to be a preference interface.,It's supposed to be a side effect caused by rewriting the global interface and changing to WinUI.,I'll try to optimize it.。 Minimizing window flickering suggests that turning on minimized dynamic refresh in Preferences - Minimization can solve this problem

That's good to hear, can you bring the newer features on the older version? it is really smooth, makes my laptop feels alive

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

elkhaligy commented 2 months ago

I'm trying to optimize it, and if it doesn't work, I'll refactor the interface, but I can't change back to the old code, because the animations and effects of the interface will be smooth with WinUI ------------------ 原始邮件 ------------------ 发件人: @.>; 发送时间: 2024年8月24日(星期六) 中午12:42 收件人: @.>; 抄送: "№じ @.>; @.>; 主题: Re: [mydockfinder/mydockfinder-for-Win10-Win11] Stage manager animation (Issue #730) It turned out to be a preference interface.,It's supposed to be a side effect caused by rewriting the global interface and changing to WinUI.,I'll try to optimize it.。 Minimizing window flickering suggests that turning on minimized dynamic refresh in Preferences - Minimization can solve this problem That's good to hear, can you bring the newer features on the older version? it is really smooth, makes my laptop feels alive — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

Ok, Thank you, may I ask what did you mean by "minimized dynamic refresh in Preferences - Minimization" I couldn't find an option like this in my settings

mydockfinder commented 2 months ago

image

elkhaligy commented 2 months ago

Oh, I just discovered a new thing, when preference is opened everything is running like 30 fps slo mo

https://github.com/user-attachments/assets/f29c2bae-23c5-4a0e-b807-440001157c4d

Compare this to the older videos, the animation got slower when preference is opened

About dynamically display windows content, it is turned off and the flickering is still present unfortunately

elkhaligy commented 2 months ago

I don't know exactly how the app is implemented but I would suggest to stay away from WinUI, it is known for its performance issues unless you have a high end machine but it is too late I guess.

mydockfinder commented 2 months ago

It's okay, it should be optimizable

chuck00000 commented 2 months ago

还有 台前调度 开启了 自动显示/隐藏桌面图标,这功能很不稳定 , 甚至把所有打开的窗口都关了,桌面图标依然是隐藏的,经常右键 选择“显示图标“, 后续能不能优化一下, 或者设置 单击一下桌面 ,能立马显示被隐藏的桌面图标,还能方便点……

mydockfinder commented 2 months ago

是不是装了第三方的桌面管理软件

------------------ 原始邮件 ------------------ 发件人: @.>; 发送时间: 2024年8月28日(星期三) 下午3:30 收件人: @.>; 抄送: "№じ @.>; @.>; 主题: Re: [mydockfinder/mydockfinder-for-Win10-Win11] Stage manager animation (Issue #730)

还有 台前调度 开启了 自动显示/隐藏桌面图标,这功能很不稳定 , 甚至把所有打开的窗口都关了,桌面图标依然是隐藏的,经常右键 选择“显示图标“, 后续能不能优化一下, 或者设置 单击一下桌面 ,能立马显示被隐藏的桌面图标,还能方便点……

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

elkhaligy commented 2 months ago

Hi, any progress on this case?

mydockfinder commented 2 months ago

I've recently had COVID

------------------ 原始邮件 ------------------ 发件人: @.>; 发送时间: 2024年9月6日(星期五) 晚上11:24 收件人: @.>; 抄送: "№じ @.>; @.>; 主题: Re: [mydockfinder/mydockfinder-for-Win10-Win11] Stage manager animation (Issue #730)

Hi, any progress on this case?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

elkhaligy commented 2 months ago

I've recently had COVID

------------------ 原始邮件 ------------------ 发件人: @.>; 发送时间: 2024年9月6日(星期五) 晚上11:24 收件人: @.>; 抄送: "№じ @.>; @.>; 主题: Re: [mydockfinder/mydockfinder-for-Win10-Win11] Stage manager animation (Issue #730)

Hi, any progress on this case?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

I'm sorry to hear that, hope you recover quickly.

mydockfinder commented 2 months ago

Thanks, I'm almost healed

------------------ 原始邮件 ------------------ 发件人: @.>; 发送时间: 2024年9月8日(星期天) 晚上7:19 收件人: @.>; 抄送: "№じ @.>; @.>; 主题: Re: [mydockfinder/mydockfinder-for-Win10-Win11] Stage manager animation (Issue #730)

I've recently had COVID

------------------ 原始邮件 ------------------ 发件人: @.>; 发送时间: 2024年9月6日(星期五) 晚上11:24 收件人: @.>; 抄送: "№じ @.>; @.>; 主题: Re: [mydockfinder/mydockfinder-for-Win10-Win11] Stage manager animation (Issue #730)

Hi, any progress on this case?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

I'm sorry to hear that, hope you recover quickly.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>