search

mydoghasworms / nwrfc

SAP Netweaver RFC SDK wrapper via Ruby-FFI
http://ceronio.net/nwrfc/
28 stars 14 forks source link

Ruby 2.0 compat #8

Closed Meatballs1 closed 9 years ago

Meatballs1 commented 9 years ago

iconv is deprecated in Ruby > 2.0.

Not sure if this works for the FFI::StructLayout::CharArray modifications..?

mydoghasworms commented 9 years ago

Sorry, I've been meaning to come back to you on this one. The deprecation warning has always been bothering me, and I have been meaning to adapt for 2.0, but I was always worried about breaking it for any other users out there. Maybe it's just a good idea to make it work for 2.0 and then users who need it for older versions can use the older gem or fork it. What do you think?

Meatballs1 commented 9 years ago

I'm happy with any approach, I'm currently pointing the gem to my own github repo but will reset it back when upstream gets updated :)

I have no real idea if my approach is the best way, encoding always scares me...

mydoghasworms commented 9 years ago

I have applied the changes, but kept support for 1.8 and older implementations, so I will not be merging this pull request. Thanks, and sorry it took so long!