myethermarket / MyEtherMarket

1 stars 0 forks source link

Check, specifically, the amountGive assumption for fillAsk #3

Closed myethermarket closed 6 years ago

myethermarket commented 6 years ago

Eth is compared in the first part of the equation, but market maker's amount give is not explicitly checked to be more than the calculated token qty deducted. Either prove that it must be more than qty deducted or add code to handle that case (i.e. double closeout). This is all caused by rounding errors.

myethermarket commented 6 years ago

Decided that a check is safest route, easy check, and good, clear, traceable result.