Open Alex313031 opened 2 years ago
https://github.com/shuax/ChromePAK and https://github.com/shuax/ChromePAK-V5 are different repos, first appears eariler, but might be deleted or made private. The code of first repo can be seen from forks like https://github.com/jackysh88/ChromePAK and pages in archive.org
The brotli encoding does not affect unpacking, it does not change the format of pak file, but files inside it, chromium devs added a header before brotli encoded stream containing a idenfier and decompressed length, so it can not be uncompressed by regular brotli util. If someone wants to just unpack the pak file, it would be ok, but some of the brotli-compressed unpacked contents would not have detected extension, and need to be modified before uncompressing with the brotli util.
Hello, I make my own chromium fork for linux, win, and macos called Thorium > https://github.com/Alex313031/Thorium/ I recently compiled pak for linux, and downloaded the windows releases, and am including them in the installers of Thorium, with a credit to you in the readme. I include it because Thorium is designed to be dev friendly, with a new UI for the reload button that includes "hard reload" and "empty cache and hard reload", and the inclusion of chromedriver, content_shell, and now pak in the installer to ease debugging, testing, and web development.
This link > https://github.com/shuax/ChromePAK in your readme needs to be updated to > https://github.com/shuax/ChromePAK-V5
On the note of that repo, Is yours up to date with his code? His latest commit is a year newer. Maybe his has a fix for the brotli thing in it already?
About the recent brotli thing, is this likely to affect someone who just wants to unpack a .pak in Thorium just to see the contents?