search

myinnos / AlphabetIndex-Fast-Scroll-RecyclerView

A Powerful AlphabetIndex FastScroller Library for Android's RecyclerView!
https://myinnos.github.io/AlphabetIndex-Fast-Scroll-RecyclerView/
Apache License 2.0
603 stars 114 forks source link

Added ability to hide the preview box #14

Closed bshafer closed 7 years ago

bshafer commented 7 years ago

I am using this to make an index bar that has an index from 1 to 150. I only show multiples of 10 on the bar, so it was displaying a blank preview box most of the time. I thought about just not displaying it when the index was "" (which is included in this code), but then I decided to just remove the preview altogether, and run with that, at least for now.

It also might be nice if the preview displayed a number even when the index bar had a blank string for that item, but that would require two strings per section (one for the index bar, and a different one for the preview), and I thought that might be too big a change.

myinnos commented 7 years ago

Thank you for your contribution, please update ReadMe as well, so that i will merge your pull request and release new version.

Thank you.

bshafer commented 7 years ago

I already updated README.md with the new setPreviewVisibility method. Is there something more you need? I didn't change the version number, because I don't know what version you will release. (This is my first pull request ever on github, so I might be missing something)

myinnos commented 7 years ago

Great, Its my mistake i didn't check readme file, Any way thank you for your contribution.

I merged your request and will release new version.

Happy Coding!