myint / language-check

Python wrapper for LanguageTool grammar checker
https://pypi.python.org/pypi/language-check
GNU Lesser General Public License v3.0
327 stars 101 forks source link

Java Version on Windows #10

Closed sils closed 9 years ago

sils commented 9 years ago

Hey, seems language-check has something against java version 1.8? You claim your setup takes care of gettting the right java stuff. Here's what we're experiencing:

https://ci.appveyor.com/project/sils1297/coala/build/1.0.1079/job/uwhqxai01o767g6i#L174

myint commented 9 years ago

I'm not familiar with AppVeyor's Java settings, but pull requests are welcome if this isn't an AppVeyor-specific problem.

myint commented 9 years ago

http://help.appveyor.com/discussions/suggestions/365-install-jdk:

Both JDK 7 and 8 have been installed on build workers:

JDK 1.7 (C:\Program Files\Java\jdk1.7.0\bin in PATH) JDK 1.8 (C:\Program Files\Java\jdk1.8.0)

JDK 1.7 is default and in PATH

sils commented 9 years ago

THanks, actually I already tried adjusting the PATH so that the right java version was taken in this commit https://github.com/coala-analyzer/coala/commit/ad7e37a0cdcd992c50e53b5442139a8be0c5c352

2015-07-08 17:12 GMT+02:00 Steven Myint notifications@github.com:

http://help.appveyor.com/discussions/suggestions/365-install-jdk

— Reply to this email directly or view it on GitHub https://github.com/myint/language-check/issues/10#issuecomment-119619403 .