search

myint / language-check

Python wrapper for LanguageTool grammar checker
https://pypi.python.org/pypi/language-check
GNU Lesser General Public License v3.0
327 stars 101 forks source link

_server_is_alive checks only for local server #41

Closed SankethPinchMe closed 7 years ago

SankethPinchMe commented 7 years ago

The way class method _server_is_alive is written it only checks for the local server. When LanguageTool instance is created with a remote server _server_is_alive fails to check the remote server and starts a local server.

myint commented 7 years ago

Thanks for the report! Could you check if 7a541bf0b390f0525233bec8749e2535fd59875a fixes the problem?

Thanks

2ank3th commented 7 years ago

Yes, this fixes the problem. I was working on a fix myself but it included a check if the remote server is working or not.

Do you still want me to work on that?

Thanks

myint commented 7 years ago

@2ank3th Sure, I think a check of the remote server would be useful. Thanks!