search

myint / language-check

Python wrapper for LanguageTool grammar checker
https://pypi.python.org/pypi/language-check
GNU Lesser General Public License v3.0
326 stars 102 forks source link

can't install from the git repo with OpenJDK #54

Open jeanbaptisteb opened 6 years ago

jeanbaptisteb commented 6 years ago

Config:

I tried to install language-check from pip, and the installation works. But then, when I try using it in some Python code, it throws some error.

So I tried to install language-check directly from the git repo, as suggested in another issue, with: pip3 install git+https://github.com/myint/language-check.git But then I get:

Could not parse Java version from """openjdk version "10.0.1" 2018-04-17 OpenJDK Runtime Environment (build 10.0.1+10-Ubuntu-3ubuntu1) OpenJDK 64-Bit Server VM (build 10.0.1+10-Ubuntu-3ubuntu1, mixed mode

I also tried installing it on Windows, with the following configuration, and in this case it works like a charm:

So I guess that the problem comes from OpenJDK on Ubuntu.

Any advice?

Bachstelze commented 6 years ago

Same issue here with the 18.04 ubuntu desktop image. Got this error message:

Running setup.py bdist_wheel for language-check ... error

  Complete output from command /home/bag_of_words/bin/python3 -u -c "import setuptools, tokenize;__file__='/tmp/pip-install-w08w5t2o/language-check/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" bdist_wheel -d /tmp/pip-wheel-wap2l03f --python-tag cp36:
  Could not parse Java version from """openjdk version "10.0.1" 2018-04-17
  OpenJDK Runtime Environment (build 10.0.1+10-Ubuntu-3ubuntu1)
  OpenJDK 64-Bit Server VM (build 10.0.1+10-Ubuntu-3ubuntu1, mixed mode)
jeanbaptisteb commented 6 years ago

Hmm, it seems to be a duplicate of https://github.com/myint/language-check/issues/31, isn't it?

Bachstelze commented 6 years ago

Yes, should be a duplication because they also can not parse the java version with this regex, but it is not failing with only one certain java version. You can try my Pull-request or delete on your own 3 characters :D

56

Bachstelze commented 5 years ago

This should be fixed with https://github.com/myint/language-check/pull/57 Can we make a new release for pip with this bug fix?

jxmorris12 commented 4 years ago

Hi! Since this project has been abandoned, I started a new fork over at https://github.com/jxmorris12/language_tool_python.

My version supports new versions of Java and LanguageTool. language-check is stuck on Java 8 and LanguageTool 3.2; latest versions are Java 14 and LanguageTool 4.9!

I'm happy to help you with your issue if you raise it over at my repository! Thanks!