myitcv / x

Mono-repo for all myitcv.io/... Go code
MIT License
103 stars 20 forks source link

react: Form OnSubmit not mapped in FormProps #51

Closed myitcv closed 6 years ago

myitcv commented 6 years ago

Straight link/copy of https://github.com/myitcv/react/issues/159 now that everything has moved to the mono-repo

cc @asafo

myitcv commented 6 years ago

@asafo - apologies for the very delayed response to your issue.

Is there a reason why this event isn't mapped ?

No reason, other than it is simply missing from the template used for the core component generator: https://github.com/myitcv/x/blob/df0e6d2b54fffdff5ee716f1fa171381cfdeddf6/react/cmd/coreGen/elements.go

I've just merged #67 to address this, which coincidentally gives an example of how to add further HTML elements/attributes (one day we will generate from the spec)