ComponentDidUpdate - Githubissues

myitcv / x

Mono-repo for all myitcv.io/... Go code

MIT License

103 stars 20 forks source link

ComponentDidUpdate #69

Closed pjebs closed 5 years ago

pjebs commented 5 years ago

There is no support for componentDidUpdate(prevProps, prevState, snapshot) which is important when interacting with other libraries that directly interfere with the DOM

It gets called after Render.

See: https://github.com/myitcv/react/wiki/Creating-a-GopherJS-React-app#other-lifecycle-methods See: https://reactjs.org/docs/react-component.html

myitcv commented 5 years ago

I need to give some thought to what this actually means in terms of prevProps and prevState, but I don't have any objection to adding this in principle.

pjebs commented 5 years ago

Where in the codebase would componentDidUpdate get potentially called?

pjebs commented 5 years ago

Closing because I created my own bindings: https://github.com/rocketlaunchr/react/