search

myitcv / x

Mono-repo for all myitcv.io/... Go code
MIT License
103 stars 20 forks source link

CSS complete #71

Open pjebs opened 5 years ago

pjebs commented 5 years ago

Used https://play.golang.org/p/uK-9pocUmVE Only CSS 3 are included.

pjebs commented 5 years ago

I added the attributes for html input element.

Can you double check it because I didn't quite understand Attr what the html field was meant to be for.

What I did was:

  1. Got the supported fields from https://godoc.org/honnef.co/go/js/dom#HTMLInputElement
  2. Processed them using this code (can you double check please): https://play.golang.org/p/jBzxwYzDjgl
  3. Copied and Pasted and then ran gofmt
  4. Human verified it to the best of my ability
pjebs commented 5 years ago

You can see for ValueAsDate I was unsure what to do with a time.Time object. For ValueAsNumber I was unsure what to do with the type being float64

Re: lowercase for html attribute - https://stackoverflow.com/questions/36176474/camel-case-in-html-tag-attributes-and-jquery-doesnt-work-why

pjebs commented 5 years ago

I added more stuff but was a bit unsure how to deal with events. commit: 1483549

pjebs commented 5 years ago

iframe.srcdoc may need to be checked too

pjebs commented 5 years ago

@myitcv Are there any concerns, suggestions or feedback about this PR?

myitcv commented 5 years ago

@pjebs I'm trying to find time to look through this, apologies for the delay.

Woellchen commented 5 years ago

bump. would like to see that merged :)

pjebs commented 5 years ago

@Woellchen I got it merged in my new package: https://medium.com/@rocketlaunchr.cloud/go-with-react-de5ee4f01df9