Rating calc: updating +Rating column with new rank

myjian / mai-tools

mai-tools is a collection of useful tools for maimai and maimai DX.

https://myjian.github.io/mai-tools

GNU General Public License v3.0

39 stars 11 forks source link

Rating calc: updating +Rating column with new rank #102

Closed TrinityBeam closed 3 months ago

TrinityBeam commented 3 months ago

Update the +Rating column in the rating calculator to show what the rating will change to after reaching a particular threshold. Also maintain functionality by keeping the numerical increase in parenthesis

Tested via manual input on a local dev build on all supported languages

myjian commented 3 months ago

Can you also update getColumnTitle() in src/rating-calculator/components/ChartRecordHeadRow.tsx? I would like to replace messages.nextRating with CommonMessages[lang].rating for ColumnType.NEXT_RATING. (and delete the translations for nextRating)

TrinityBeam commented 3 months ago

Updated ColumnType.NEXT_RATING with CommonMessages[lang].rating and also removed the translations for nextRating

TrinityBeam commented 3 months ago

@myjian CSS on mobile is a bit flaky - let me retest a couple of scenarios with mobile UI and raise a new PR

Apologies in advance 😞