myles-lewis / locuszoomr

A pure R implementation of locuszoom for plotting genetic data at genomic loci accompanied by gene annotations.
GNU General Public License v3.0
18 stars 5 forks source link

genome build option for LD #13

Closed nnishiyama closed 9 months ago

nnishiyama commented 9 months ago

Any chance you can include an option in the link_LD() function to choose the genome build as LDlinkR now supports multiple builds? Thanks!

myles-lewis commented 9 months ago

Hi nnishiyama,

Good suggestion. I have added ... to link_LD() to allow passing of arguments through to LDlinkR function LDmatrix(). So now you can add the argument genome_build to the link_LD() call.

Bw, Myles

myles-lewis commented 9 months ago

Hi nnishiyama,

Just to warn you that I have just pushed another update to locuszoomr main branch to rename the LDtoken argument to token. It's shorter, simpler and more consistent with all the other LDlinkR arguments. So you'll need to update your calls to link_LD() when using the latest version.

Bw, Myles

nnishiyama commented 9 months ago

Fantastic. Thanks for the heads up!